Jump to content


Photo
Issue

External link's underline spreading through a space

wiki

  • Please log in to reply
21 replies to this topic

#1 hishutup

hishutup

    Daedric Prince

  • Super Moderators
  • PipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPip
  • 2,572 posts

Posted 23 December 2014 - 07:18 PM

I don't really know how to explain this but the underline from a link is going through a space that isn't part of the link.

===== [[File:Blue_Box.png|20px|link=|bottom]] [http://www.nexusmods.com/oblivion/mods/44069/ Alive Waters updated] =====

will result in something like this

 

I would think that this was an issue but its new and wasn't originally like that.



#2 z929669

z929669

    Ixian Inventor

  • Administrators
  • PipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPip
  • 9,245 posts

Posted 24 December 2014 - 01:16 PM

Unrelated, but I reduced your top image to a more realistic size ... revert if you want, but it was too big IMO.

 

As far as underlines in links, that is the standard behavior ...

[http://www.nexusmods.com/oblivion/mods/44069/ Alive Waters updated]

will render on the wiki as:

Alive Waters updated

 

... not sure what you are linking to in your post



#3 hishutup

hishutup

    Daedric Prince

  • Super Moderators
  • PipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPip
  • 2,572 posts

Posted 24 December 2014 - 01:47 PM

Oops, Ill explain the link thing later but here is the new one.

 

This is the underline.

da31a76bee.png

 

My first thought was that it is in the css but there nothing in the h5{} section. 

Unless there is another section that is bleeding over, which I doubt.

 

There one one time that the line continued on the through the image but that underline wasn't originally there because it looks terrible.

 

The image is a different deal but I cant get it to scale...

Is there a way to use parser function or simple math to get the size because the image needs to be reduced by ~100px from the monitor width because of the space on the left side?

I know DoubleYou gave it a shot but couldn't get it to work. 

 

EDIT:

This is obviously wrong and it never used to be like that...

9468e2176f.png



#4 TechAngel85

TechAngel85

    Akatosh

  • Administrators
  • PipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPip
  • 11,794 posts

Posted 24 December 2014 - 05:06 PM

The link is taking up the entire header; thus, you're seeing the link (line) go across the entire space the header is taking up. Chalk this up to odd wiki behavior. Where you use <span> elements you're seeing the line because it is an invisible text element (blank spaces) with a background color; thus, there is nothing to cover up the line. When you use the image, you don't see the line because it is not an invisible element. It's an image covering up the line so that it's no longer visible.

 

I've played with it and can't seem to get it to stop underlining the section that isn't the link. Wiki behavior...



#5 hishutup

hishutup

    Daedric Prince

  • Super Moderators
  • PipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPip
  • 2,572 posts

Posted 24 December 2014 - 05:08 PM

I know its weird because it wasn't there when I was writing it.

I don't think I have any open tags anywhere.

I doubt I would miss something like that because it is pretty obvious.

 

On the second image, it uses the nonbreaking space, thats why the line is through it.

In other words, the second image is not a image it a colored background but the first image that I posted with the black arrow, is in fact an image using the wiki code that I posted above.



#6 DoubleYou

DoubleYou

    Wiki Stepper

  • Super Moderators
  • PipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPip
  • 4,466 posts

Posted 24 December 2014 - 05:36 PM

Obvious solution would be make the image include the space. Perhaps a better solution would be to somehow move the color box outside the h5 somehow.



#7 hishutup

hishutup

    Daedric Prince

  • Super Moderators
  • PipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPip
  • 2,572 posts

Posted 24 December 2014 - 05:39 PM

I dont think I can... 
In the beginning, I was trying various things to find a good solution on the colored boxes and this is what I had settled on...

===== [[File:Blue_Box.png|20px|link=|bottom]] [<url> <mod name>] =====

so about 3/4 of the guide is in that format. 

After switching to an image, the TOC garbage has disappeared and now it look have decent.



#8 stoppingby4now

stoppingby4now

    Sleepy

  • Administrators
  • PipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPip
  • 4,281 posts

Posted 27 December 2014 - 09:10 PM

What you are seeing is because of the H5 element which has a text-decoration of "underline" applied to it. Wiki headers get wrapped within a span element tagged with a class of "mw-headline", and you are clearly including the image and the link within the header element, and thus the underline gets applied.

 

It has nothing to do with the link, and is not "odd wiki behavior". It's perfectly normal.

 

Applying additional "stuff" inside a header is uncommon. They were meant to be plain text, and adding images, links, and whatever else one could attempt to do is bound to produce odd behavior.



#9 hishutup

hishutup

    Daedric Prince

  • Super Moderators
  • PipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPip
  • 2,572 posts

Posted 27 December 2014 - 09:17 PM

I understand that it is abnormal and would expect something strange to happen but the reason that I did bring it up is because it wasn't like that before. Its a fairly new effect. I took a glance at the .css and there wasn't any changes that were made to the h5.

 

Is there a better way to have the same effect or is it kinda stuck the way it is?

I think I can figure out a way to make the link disappear but it would be kinda hackish. I see that multiple people have attempted to make the annoying line go away and it didn't matter.

 

Man those lines like my guide, what more can I say.



#10 TechAngel85

TechAngel85

    Akatosh

  • Administrators
  • PipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPip
  • 11,794 posts

Posted 27 December 2014 - 09:53 PM

@s4n,

Yeah, I thought about that image being in the head as being odd after the fact.

 

@hishutup,

You can use divs to float the images to the left of the headers. This would eliminate the issue entirely. You could try adding the follow to your css file for the h5 element:

  • text-decoration: none;

That might eliminate the issue. I can't edit your .css page (which is odd because I should have the permissions to do that) or I'd try it for you.



#11 hishutup

hishutup

    Daedric Prince

  • Super Moderators
  • PipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPip
  • 2,572 posts

Posted 27 December 2014 - 10:14 PM

doubleyou already gave that a shot and I guess it didn't do anything because he didnt mention it

 

Tech, I dont think anyone has the perms other than full admins.

I am unsure why moderators and up don't have the perms though. 

If you feel like going through the effort then put it on a regular wiki page and I'll just copy/paste it.

 

There is no rush though.



#12 stoppingby4now

stoppingby4now

    Sleepy

  • Administrators
  • PipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPip
  • 4,281 posts

Posted 27 December 2014 - 10:16 PM

Just a gentle reminder that the css extension will be going away when the wiki skin is refreshed. Far too much hacking going on with it.

#13 hishutup

hishutup

    Daedric Prince

  • Super Moderators
  • PipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPip
  • 2,572 posts

Posted 27 December 2014 - 10:24 PM

I completely dislike and upset by that.

So, I have to use a mix of html and css to make my guide look the way it is?

Is every wiki page going to look the same because I am not okay with that.



#14 stoppingby4now

stoppingby4now

    Sleepy

  • Administrators
  • PipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPip
  • 4,281 posts

Posted 27 December 2014 - 10:30 PM

There will be things implemented in the skin within reason based on feed back when we get to that point. But yes, we do need consistency within the Wiki, and the css extension is being used for purposes it was not intended for. Sorry, but it's being abused and will continue to be as long as it's available.

Certain styling can still be applied in wiki text, but modifying major elements that isn't supported by MW will be discontinued in the future.

#15 hishutup

hishutup

    Daedric Prince

  • Super Moderators
  • PipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPip
  • 2,572 posts

Posted 27 December 2014 - 10:39 PM

Even though it is off topic, what exactly do you mean by abuse?

Is what tech said abusing it?

I would call it a temporary workaround because something unexpected changed without me knowing. 

I don't know about you but I was expecting more freedom and features in the future rather than restrictions and losing widely used features. 





Also tagged with one or more of these keywords: issue, wiki

0 user(s) are reading this topic

0 members, 0 guests, 0 anonymous users