Jump to content


Photo
Non-Issue

Change the Background Image



  • Please log in to reply
25 replies to this topic

#16 z929669

z929669

    Ixian Inventor

  • Administrator
  • PipPipPipPipPipPipPipPipPipPipPipPipPipPipPip
  • 7,082 posts

Posted 31 March 2014 - 11:28 AM

!important is not declared in the site CSS for that element attribute, so that is not the issue. if you inspect the element, you will see that the background-image path is being pre-pended from elsewhere and the CSS is appending the path.

 

Let's let s4n explain.



#17 TechAngel85

TechAngel85

    Akatosh

  • Administrator
  • PipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPip
  • 13,040 posts

Posted 31 March 2014 - 11:33 AM

Okay, thanks for checking it out. :psyduck:

 

Wating for s4n....commencing gnome dance... :gnome:



#18 stoppingby4now

stoppingby4now

    Sleepy

  • Founder
  • PipPipPipPipPipPip
  • 2,419 posts

Posted 31 March 2014 - 02:57 PM

I'm not entirely sure what method is being used, as Z linked me to https://wiki.step-pr.../MassEffect.css. Overriding CSS is applied Wiki wide, and is done by either overriding a specific skin, or making global changes. In our case, both will have the same effect since we only have one skin enabled.

 

SKIN SPECIFIC

https://wiki.step-pr...MyPage/step.css

GLOBAL

https://wiki.step-pr...Page/common.css

 

The link that Z provided me from Tech is not valid and will not override anything.

 

There is the CSS extension, but that was only installed as a workaround for the STEP guide. It is not intended for the masses to modify pages, thus altering the default look as it applies to everyone. Once MediaWiki is updated and the skin updated (which is required due to changes in MW), changes will be made to better support the Guide and similar rare cases where the CSS extension was necessary, thus making it obsolete and removed.


  • 0

#19 z929669

z929669

    Ixian Inventor

  • Administrator
  • PipPipPipPipPipPipPipPipPipPipPipPipPipPipPip
  • 7,082 posts

Posted 31 March 2014 - 03:01 PM

Tech is speaking about altering behavior of just one page to reflect look/feel for all users relating to a different game. He is specifically invoking the CSS extension behavior, which works but for the case with page-specific fonts and background image.

 

Page: https://wiki.step-pr...el85/MassEffect

CSS: https://wiki.step-pr.../MassEffect.css

 

Neovalen and EssArrBee use the same method for their guides (as we do for the STEP Guide). It is perplexing why the background atribute cannot be applied. Can you determine why it disables all of the custom page-specific css?



#20 stoppingby4now

stoppingby4now

    Sleepy

  • Founder
  • PipPipPipPipPipPip
  • 2,419 posts

Posted 31 March 2014 - 03:31 PM

The plan has always been to get away from needing the CSS extension. It was never intended to be used by everyone.

 

If we are at the point of looking to start support for additional games, we might want to see about standing up additional instances of MW so they have a common look and feel that is their own.

 

In addition, I just checked the page you linked, and I see the background image applied.


  • 0

#21 z929669

z929669

    Ixian Inventor

  • Administrator
  • PipPipPipPipPipPipPipPipPipPipPipPipPipPipPip
  • 7,082 posts

Posted 31 March 2014 - 03:35 PM

Our background image is applied because the body element is commented. Try uncommenting and looking at the result. There is also no way to apply the masEffect image to the bakcground.



#22 stoppingby4now

stoppingby4now

    Sleepy

  • Founder
  • PipPipPipPipPipPip
  • 2,419 posts

Posted 31 March 2014 - 03:49 PM

There was a problem we experienced where the first element override was not applied on the STEP guide, and the fix was to create an empty reference. Doesn't appear to be working here. I have no idea why it's not working. Maybe it's because the css on a page that is the standard for user overrides. Maybe the extension doesn't allow overriding the body (the MW page says you can, but who knows if that changed and documentation wasn't updated).

 

Plan is still to eventually get rid of the CSS extension.


  • 0

#23 z929669

z929669

    Ixian Inventor

  • Administrator
  • PipPipPipPipPipPipPipPipPipPipPipPipPipPipPip
  • 7,082 posts

Posted 31 March 2014 - 03:54 PM

All CSS works except that particular background-image element. When uncommented, it disables all of the other CSS.

 

It IS working, but just not that element. If you inspect the page (the Mas Effect Guide page where the custom CSS is being applied), you will notice that it does not even appear in the Inspector, regardless of using !important or not.

 

Why does ALL custom CSS work (including body {}) but if the img() attribute is applied, EVERYTHING breaks ... ?



#24 DoubleYou

DoubleYou

    Wiki Stepper

  • Step Admin
  • PipPipPipPipPipPipPipPipPipPipPip
  • 4,868 posts

Posted 31 March 2014 - 04:01 PM

As a clue, you can setup a custom <div> element to have a colored background (see my user page for and example) but as soon as you apply the url('path-to-image') data to the object, it parses the < to a &lt, rendering it useless. With what little tinkering I've done with coding, this is probably a php permissions/security thing, which is blocking the css once a background image is added.


  • 0

#25 stoppingby4now

stoppingby4now

    Sleepy

  • Founder
  • PipPipPipPipPipPip
  • 2,419 posts

Posted 31 March 2014 - 07:01 PM

Not 100% sure without further inspection of code, but based on the hook points that are required for the CSS extension to work, I'm almost certain it is due to the MW parser rejecting the URL. There are protections built into MW to prevent people from doing bad things (can't use anchors directly, have to use MW markup for URL's so they are properly sanitized, etc.). If that is the case, nothing we can do about it without opening ourselves wide open to much more serious problems.

 

EDIT: Just read DoubleYou's post, and I'm absolutely certain now it's the parser scrubbing the contents and ultimately breaking the CSS entirely due to invalid formatting.

 

Result: no changing of background using url's.


  • 0

#26 TechAngel85

TechAngel85

    Akatosh

  • Administrator
  • PipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPipPip
  • 13,040 posts

Posted 31 March 2014 - 09:05 PM

Thanks for checking in this guys!

 

It's not that big a deal. It would have just been nice to been able to change it. The skyrim reference in the background of a game guide that isn't skyrim (such as my Mass Effect Enhancement Guide and the Fallout: New Vegas Guide) doesn't make much sense. No room to complain when it's been hosted for free. ::): I'm planning on ME2 and ME3 Guides as well....depend if the scope is big enough to do those guides or not. Currently not making them publicly known like the FNV Guide though until I can hash out a few issues.

 

Thanks again!





Also tagged with one or more of these keywords: non-issue

0 user(s) are reading this topic

0 members, 0 guests, 0 anonymous users